[bsp][k230]:add gnne driver by ChuanN-sudo · Pull Request #11092 · RT-Thread/rt-thread

ChuanN-sudo · 2025-12-25T13:49:03Z

Requirement: The BSP for the k230 platform in the RT-Thread repository does not yet have a gnne driver.

Solution: Provide gnne driver for the k230 platform in the RT-Thread repository.

Implements mutex lock mechanism for AI2D and GNNE modules.
Adds HARDLOCK_AI2D support in hardlock driver for mutual exclusion.
Implements poll operation for device status monitoring.
Updates documentation in bsp/README.md.

Signed-off-by: ChuanN-sudo fjchuanil@gmail.com

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

为K230添加gnne驱动

你的解决方案是什么 (what is your solution)

添加gnne驱动

请提供验证的bsp和config (provide the config and bsp)

BSP:/bsp/k230/drivers/interdrv/gnne
.config:
action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
代码是高质量的 Code in this PR is of high quality
已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

github-actions · 2025-12-25T13:49:12Z

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

前往 Actions 页面 | Go to the Actions page
点击进入工作流 → | Click to open workflow →
点击 Run workflow | Click Run workflow

设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：k230-add-gnne-driver
设置PR number为 \ Set the PR number to：11092

等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 k230-add-gnne-driver 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the k230-add-gnne-driver branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions · 2025-12-25T13:49:13Z

📌 Code Review Assignment

🏷️ Tag: bsp_k230

Reviewers: unicornx

Changed Files (Click to expand)

bsp/k230/.ci/attachconfig/ci.attachconfig.yml
bsp/k230/.config
bsp/k230/board/Kconfig
bsp/k230/drivers/interdrv/gnne/SConscript
bsp/k230/drivers/interdrv/gnne/ai2d_dev.c
bsp/k230/drivers/interdrv/gnne/ai_module.c
bsp/k230/drivers/interdrv/gnne/gnne_dev.c
bsp/k230/drivers/interdrv/hardlock/drv_hardlock.h

📊 Current Review Status (Last Updated: 2025-12-26 11:55 CST)

⌛ unicornx Pending Review

📝 Review Instructions

维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
Maintainers can refresh the review status by clicking here: 🔄 Refresh Status
确认审核通过后评论 LGTM/lgtm
Comment LGTM/lgtm after confirming approval
PR合并前需至少一位维护者确认
PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

unicornx · 2025-12-26T00:35:00Z

bsp/k230/board/Kconfig

 menu "Drivers Configuration"
+
+    config BSP_USING_GNNE
+        bool "Enable GNNE"


建议在标题中不要用 GNNE 的缩写，用全称比较好理解

嘉楠的手册中似乎没用对gnne的全称，gnne这个名称和kpu是混用的，他们的Memory Map地址也是同一个，要不我直接在标题中说明一下包含KPU和AI2D？

建议先问问，实在说不清就算了，否则又是一笔糊涂账

unicornx · 2025-12-26T00:43:03Z

bsp/k230/drivers/interdrv/gnne/ai2d_dev.c

+        g_ai2d_lock  = HARDLOCK_AI2D;
+    }
+
+#ifndef RT_FASTBOOT


RT_FASTBOOT 这是一个新引入的宏，但是没有看到可以定义的地方，请确认是否需要？

RTT for CanMV Upstream Plan这个表里面提到了RT_FASTBOOT这个宏(938e5a0 bsp: k230: enable FASTBOOT)，似乎是未来准备加上的功能，老师您看在驱动中是否有必要保留对fastboot的支持，还是直接删除

这个 FASTBOOT 功能以前问过，记得不是一个必需的，先不加了，以后确定了再加。

unicornx · 2025-12-26T00:43:22Z

bsp/k230/drivers/interdrv/gnne/gnne_dev.c

+    {
+        g_kpu_lock  = HARDLOCK_KPU;
+    }
+#ifndef RT_FASTBOOT


RT_FASTBOOT 这是一个新引入的宏，但是没有看到可以定义的地方，请确认是否需要？

unicornx · 2025-12-26T00:47:50Z

bsp/k230/drivers/interdrv/gnne/ai2d_dev.c

+    .poll = ai_2d_device_poll,
+};
+
+#define IRQN_AI2D_INTERRUPT    (16 + 175)


bsp/k230/board/irq_num.h 里已经统一定义了所有的 IRQ#，请使用统一的定义。

unicornx · 2025-12-26T00:48:13Z

bsp/k230/drivers/interdrv/gnne/gnne_dev.c

+    .poll = gnne_device_poll,
+};
+
+#define IRQN_GNNE_INTERRUPT    (16 + 173)


bsp/k230/board/irq_num.h 里已经统一定义了所有的 IRQ#，请使用统一的定义。

unicornx · 2025-12-26T00:52:54Z

bsp/k230/drivers/interdrv/gnne/ai2d_dev.c

+    }
+
+    rt_wqueue_init(&ai_2d_device->wait_queue);
+    rt_hw_interrupt_install(IRQN_AI2D_INTERRUPT, irq_callback, &ai_2d_device->wait_queue, "ai_2d_irq");


rt_hw_interrupt_install 该函数可能失败，需要判断返回值。

unicornx · 2025-12-26T00:53:17Z

bsp/k230/drivers/interdrv/gnne/gnne_dev.c

+    }
+
+    rt_wqueue_init(&gnne_device->wait_queue);
+    rt_hw_interrupt_install(IRQN_GNNE_INTERRUPT, irq_callback, &gnne_device->wait_queue, "gnne_irq");


rt_hw_interrupt_install 该函数可能失败，需要判断返回值。

Requirement: The BSP for the k230 platform in the RT-Thread repository does not yet have a gnne driver. Solution: Provide gnne driver for the k230 platform in the RT-Thread repository. - Implements mutex lock mechanism for AI2D and GNNE modules. - Adds HARDLOCK_AI2D support in hardlock driver for mutual exclusion. - Implements poll operation for device status monitoring. - Updates documentation in bsp/README.md. Signed-off-by: ChuanN-sudo <fjchuanil@gmail.com>

unicornx · 2025-12-26T11:55:25Z

@Rbb666 请 review & merge if LGTY

github-actions bot added the BSP label Dec 25, 2025

unicornx self-requested a review December 26, 2025 00:31

unicornx suggested changes Dec 26, 2025

View reviewed changes

ChuanN-sudo force-pushed the k230-add-gnne-driver branch from df25c9d to ffe39f1 Compare December 26, 2025 03:24

ChuanN-sudo force-pushed the k230-add-gnne-driver branch from ffe39f1 to d61c236 Compare December 26, 2025 03:54

ChuanN-sudo requested a review from unicornx December 26, 2025 06:15

unicornx approved these changes Dec 26, 2025

View reviewed changes

unicornx requested a review from Rbb666 December 26, 2025 11:54

Rbb666 approved these changes Dec 26, 2025

View reviewed changes

Rbb666 merged commit 239f371 into RT-Thread:master Dec 26, 2025
32 checks passed

Conversation

ChuanN-sudo commented Dec 25, 2025

拉取/合并请求描述：(PR description)

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

github-actions bot commented Dec 25, 2025

🛠 操作步骤 | Steps

Uh oh!

github-actions bot commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📌 Code Review Assignment

🏷️ Tag: bsp_k230

📊 Current Review Status (Last Updated: 2025-12-26 11:55 CST)

📝 Review Instructions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

unicornx commented Dec 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 25, 2025 •

edited

Loading